Each to their own!
For me, it all hinges on what strain relief and cable clamping is provided. A D-type has decent provision for this so potting up a D-type seems daft to me, and IP67 rated backshells are available so its not a case of waterproofing. Use a decent crimp D_type and I can't believe it would fail.
But a loom adapter made from an ECU header has no strain relief so potting is the only realistic way to give it mechanical strength - and soldering is the best way as a random crimp terminal may not be quite right and become intermittent...as has been observed!!
A soldered wire on a terminal is a dangerous thing without strain relief as it is inflexible and prone to stress cracking. For example, soldering a crimp terminal (done by people without the right crimp tool) is a total recipe for disaster!
As I said - each to their own and do what works for you
